Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some things from British to American spelling #3367

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

lgoettgens
Copy link
Member

As brought up in #3330 (comment).
This explicitely does not deal with normalise.

Can somebody with access to the book please check if the two new deprecations are an issue?

Copy link
Member

@micjoswig micjoswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@joschmitt
Copy link
Member

Can somebody with access to the book please check if the two new deprecations are an issue?

Neither factorisations nor centraliser are used in code in the book as of now.

@lgoettgens lgoettgens added the backport 1.0.x Should be backported to the release 1.0 branch label Feb 14, 2024
@benlorenz benlorenz merged commit d373a85 into oscar-system:master Feb 16, 2024
20 checks passed
benlorenz pushed a commit that referenced this pull request Feb 16, 2024
* `factorisations` -> `factorizations`

* comment and docu fixes

* Add `centraliser` -> `centralizer` deprecation

* `neighbour` -> `neighbor`
@benlorenz benlorenz mentioned this pull request Feb 16, 2024
33 tasks
@lgoettgens lgoettgens deleted the lg/BE-vs-AE branch February 16, 2024 13:02
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 19, 2024
benlorenz added a commit that referenced this pull request Feb 23, 2024
### Backported PRs

- [x] #3367
- [x] #3379 
- [x] #3369
- [x] #3291
- [x] #3325
- [x] #3350 
- [x] #3351
- [x] #3365 
- [x] #3366
- [x] #3382
- [x] #3373
- [x] #3341
- [x] #3346
- [x] #3381
- [x] #3385
- [x] #3387 
- [x] #3398 
- [x] #3399 
- [x] #3374 
- [x] #3406 
- [x] #2823
- [x] #3298
- [x] #3386 
- [x] #3412 
- [x] #3392 
- [x] #3415 
- [x] #3394
- [x] #3391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants