Make partitions and (semi)standard_tableaux return iterators
#3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
force-pushed
the
js/iterators
branch
from
01c7419
to
0079648
Compare
... the quick and dirty way to have a stable API
joschmitt
force-pushed
the
js/iterators
branch
from
0079648
to
414333c
Compare
lgoettgens
added
the
backport 1.0.x
|
Merge? |
benlorenz
pushed a commit
that referenced
this pull request
Feb 19, 2024
... the quick and dirty way to have a stable API
benlorenz
removed
the
backport 1.0.x
benlorenz
added a commit
that referenced
this pull request
Feb 23, 2024
### Backported PRs - [x] #3367 - [x] #3379 - [x] #3369 - [x] #3291 - [x] #3325 - [x] #3350 - [x] #3351 - [x] #3365 - [x] #3366 - [x] #3382 - [x] #3373 - [x] #3341 - [x] #3346 - [x] #3381 - [x] #3385 - [x] #3387 - [x] #3398 - [x] #3399 - [x] #3374 - [x] #3406 - [x] #2823 - [x] #3298 - [x] #3386 - [x] #3412 - [x] #3392 - [x] #3415 - [x] #3394 - [x] #3391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... the quick and dirty way to have a stable API.
There is no real change here, but it was agreed in #3159 that these functions should return iterators and not arrays. Back then I assumed, there would be some months before 1.0 to make this fundamental change. As this is apparently not the case, I just aim to get the API right for now.
Note: if we ever decide afterwards to return to arrays (and introduce e.g.
iterate_partitions), we can still do that WITHOUT breaking API because arrays are iterable.The other direction doesn't work because an iterator does e.g. not support
getindex.