Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive bids which responds before PREBID_TIMEOUT #582

Closed
tmkdudek opened this issue Aug 30, 2016 · 4 comments · Fixed by #641
Closed

Receive bids which responds before PREBID_TIMEOUT #582

tmkdudek opened this issue Aug 30, 2016 · 4 comments · Fixed by #641

Comments

@tmkdudek
Copy link

Hi,

If we set PREBID_TIMEOUT = 1000, and one of bidders take 1.5s to respond, while others responds in 500ms. Handler below ( bidsBack) doesn't fire and i haven't any bid results. Is it possible to fix that,?

` pbjs.requestBids({

        bidsBackHandler: sendAdserverRequest

    });`
@protonate
Copy link
Collaborator

Do you have a test page that demonstrates this behavior?

@tmkdudek
Copy link
Author

Sure,
use example
http://jsfiddle.net/bhn3xk2j/104/

In this example, prebid make 2 requests. Run Fiddler, and delay one of them by e.g 5000ms.
http://ib.adnxs.com/jpt?callback=pbjs.handleAnCB&callback_uid=2639d169b70979&psa=0&id=4799418&size=300x250&promo_sizes=300x600&referrer=http%3A%2F%2Ffiddle.jshell.net%2Fbhn3xk2j%2F101%2Fshow%2F

http://ib.adnxs.com/jpt?callback=pbjs.handleAnCB&callback_uid=39f06e4a2e55c6&psa=0&id=4799418&size=728x90&promo_sizes=970x90&referrer=http%3A%2F%2Ffiddle.jshell.net%2Fbhn3xk2j%2F101%2Fshow%2F

Then, open dev console in e.g Chrome, and you will see logs:

PREBID TIMEOUT - MUST SEND ADSERVER REQUEST
BIDS BACK

Timeout happens earlier than bids back, and adserver request don't have access to bid results.

@mkendall07
Copy link
Member

may be related to #604

@tmkdudek
Copy link
Author

Thanks, it is related.

mkendall07 pushed a commit that referenced this issue Sep 19, 2016
* use a global cbTimeout to set current timeout while preserving default and accepting custom timeout passed to requestBids

* make `cbTimeout` declaration specific

* adds a "timeout buffer" to allow time to respond to be variably longer than the auction timeout

* allow timeoutBuffer to be set from pub page
marian-r added a commit to aol/Prebid.js that referenced this issue Sep 23, 2016
…3.0 to master

* commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits)
  Added support for new adapters introduced in 0.13.0 into AOL analytics
  Updated CHANGELOG
  Fixed merge conflict
  Prebid 0.13.0 Release
  Resolves prebid#635 (prebid#640)
  Add IX Deal Support (prebid#638)
  Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641)
  added timeouts to rubicon adapter that consider time-to-start costs (prebid#629)
  Modify handling of no-bids in Krux Link adapter (prebid#628)
  Allow bypassing ajax preflights with config options (prebid#630)
  validateIndentation: Invalid indentation character (prebid#631)
  use `splice` rather than `slice` to remove bids from array (prebid#637)
  delete the callback before calling clearAuction (prebid#636)
  Deal override fix to resolve prebid#618 (prebid#619)
  Update package.json
  Video - create mastertagUrl from adservertag (prebid#614)
  Prevent renderAd from rendering videos (prebid#623)
  Remove unused build depencencies (prebid#622)
  Add pull request template (prebid#615)
  Openx adaptor deal update (prebid#612)
  ...
Studnicky pushed a commit to sonobi/Prebid.js that referenced this issue Oct 4, 2016
* use a global cbTimeout to set current timeout while preserving default and accepting custom timeout passed to requestBids

* make `cbTimeout` declaration specific

* adds a "timeout buffer" to allow time to respond to be variably longer than the auction timeout

* allow timeoutBuffer to be set from pub page
Studnicky pushed a commit to sonobi/Prebid.js that referenced this issue Oct 4, 2016
* use a global cbTimeout to set current timeout while preserving default and accepting custom timeout passed to requestBids

* make `cbTimeout` declaration specific

* adds a "timeout buffer" to allow time to respond to be variably longer than the auction timeout

* allow timeoutBuffer to be set from pub page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants