Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout for bids back always uses default #604

Closed
mkendall07 opened this issue Sep 6, 2016 · 2 comments
Closed

Timeout for bids back always uses default #604

mkendall07 opened this issue Sep 6, 2016 · 2 comments
Assignees
@protonate
Labels
bug
Milestone
Prebid 0.13.0

Comments

@mkendall07
Copy link
Member

mkendall07 commented Sep 6, 2016 •
edited
Loading

https://github.com/prebid/Prebid.js/blob/master/src/bidmanager.js#L84
Line 84 incorrectly checks the global timeout value (which is default) instead passed in timeout value in pbjs.requestBids()
@mkendall07 mkendall07 added the bug label Sep 7, 2016
@mkendall07
Copy link
Member Author

@protonate
This should be fixed as part of queue bids because at this point in time, we don't know which auction the bid coming back belongs to, so we can't lookup the correct timeout on the instance of this auction.

@mkendall07 mkendall07 added this to the Prebid 0.13.0 milestone Sep 7, 2016
@mkendall07 mkendall07 mentioned this issue Sep 7, 2016
Closed
@protonate protonate mentioned this issue Sep 17, 2016
Merged
1 task
mkendall07 pushed a commit that referenced this issue Sep 19, 2016
Bug fix: accept custom timeout #582 & #604 (#641)
13a89d9 
* use a global cbTimeout to set current timeout while preserving default and accepting custom timeout passed to requestBids

* make `cbTimeout` declaration specific

* adds a "timeout buffer" to allow time to respond to be variably longer than the auction timeout

* allow timeoutBuffer to be set from pub page
@mkendall07
Copy link
Member Author

Resolved in master.

marian-r added a commit to aol/Prebid.js that referenced this issue Sep 23, 2016
@marian-r
Merge pull request prebid#34 in AOLP_ADS_JS/prebid.js from release/1.…
36d2315 
…3.0 to master

* commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits)
  Added support for new adapters introduced in 0.13.0 into AOL analytics
  Updated CHANGELOG
  Fixed merge conflict
  Prebid 0.13.0 Release
  Resolves prebid#635 (prebid#640)
  Add IX Deal Support (prebid#638)
  Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641)
  added timeouts to rubicon adapter that consider time-to-start costs (prebid#629)
  Modify handling of no-bids in Krux Link adapter (prebid#628)
  Allow bypassing ajax preflights with config options (prebid#630)
  validateIndentation: Invalid indentation character (prebid#631)
  use `splice` rather than `slice` to remove bids from array (prebid#637)
  delete the callback before calling clearAuction (prebid#636)
  Deal override fix to resolve prebid#618 (prebid#619)
  Update package.json
  Video - create mastertagUrl from adservertag (prebid#614)
  Prevent renderAd from rendering videos (prebid#623)
  Remove unused build depencencies (prebid#622)
  Add pull request template (prebid#615)
  Openx adaptor deal update (prebid#612)
  ...
Studnicky pushed a commit to sonobi/Prebid.js that referenced this issue Oct 4, 2016
Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641)
e465ff1 
* use a global cbTimeout to set current timeout while preserving default and accepting custom timeout passed to requestBids

* make `cbTimeout` declaration specific

* adds a "timeout buffer" to allow time to respond to be variably longer than the auction timeout

* allow timeoutBuffer to be set from pub page
Studnicky pushed a commit to sonobi/Prebid.js that referenced this issue Oct 4, 2016
Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641)
9bef7c8 
* use a global cbTimeout to set current timeout while preserving default and accepting custom timeout passed to requestBids

* make `cbTimeout` declaration specific

* adds a "timeout buffer" to allow time to respond to be variably longer than the auction timeout

* allow timeoutBuffer to be set from pub page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@protonate protonate

Labels
bug
Projects
None yet
Milestone
Prebid 0.13.0
Development

No branches or pull requests
2 participants
@mkendall07 @protonate