-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable send all bid targets override deal targets #618
Labels
Comments
Dumtard
pushed a commit
to indexexchange/Prebid.js
that referenced
this issue
Sep 12, 2016
9 tasks
@indexexchange |
@indexexchange |
marian-r
added a commit
to aol/Prebid.js
that referenced
this issue
Sep 23, 2016
…3.0 to master * commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits) Added support for new adapters introduced in 0.13.0 into AOL analytics Updated CHANGELOG Fixed merge conflict Prebid 0.13.0 Release Resolves prebid#635 (prebid#640) Add IX Deal Support (prebid#638) Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641) added timeouts to rubicon adapter that consider time-to-start costs (prebid#629) Modify handling of no-bids in Krux Link adapter (prebid#628) Allow bypassing ajax preflights with config options (prebid#630) validateIndentation: Invalid indentation character (prebid#631) use `splice` rather than `slice` to remove bids from array (prebid#637) delete the callback before calling clearAuction (prebid#636) Deal override fix to resolve prebid#618 (prebid#619) Update package.json Video - create mastertagUrl from adservertag (prebid#614) Prevent renderAd from rendering videos (prebid#623) Remove unused build depencencies (prebid#622) Add pull request template (prebid#615) Openx adaptor deal update (prebid#612) ...
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this issue
Oct 4, 2016
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this issue
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prebid.js currently overrides deal targets with enable send all bid targets.
As per Prebid.js version 12, targets are set in the order of deals, win bid, and enable send all bids target:
The
getDealTargeting()
function sets the deal targets:hb_bidder_BIDDERCODE
,hb_adid_BIDDERCODE
,hb_pb_BIDDERCODE
,hb_size_BIDDERCODE
andhb_deal_BIDDERCODE
.However,
getBidLandscapeTargeting()
overrides all deal targets excepthb_deal_BIDDERCODE
.Example Senario:
The first bid response has deal and the second bid response does not have deal
The
getAllTargeting()
function sets the deal targets.The
getBidLandscapeTargeting()
function sets non-deal target and overrides the deal targets.Due to the override, there is a deal target (
hb_deal_BIDDERCODE: DEAL
) with non-deal adid (hb_adid_BIDDERCODE: 4c99f6b09eb5ce
); however, the adid is not associated with the deal.The text was updated successfully, but these errors were encountered: