Video - create mastertagUrl from adservertag #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to video-mastertag
…to video-mastertag
| var bidObject = $$PREBID_GLOBAL$$._bidsReceived.find(bid => bid.adUnitCode === that.code); | ||
| return bidObject; | ||
| }; | ||
| return that; |
There was a problem hiding this comment.
If you call this function as a constructor with the new keyword, you can remove lines 5 and 12 as these steps will then happen implicitly. Then change the 4 other thats to this and capitalize adserver on line 4 to prevent jshint from giving a warning.
There was a problem hiding this comment.
@matthewlane thanks.
|
@jaiminpanchal27 left a few code notes. Also it'd be good to have unit tests for the new functions. Looking good! |
| @@ -0,0 +1,57 @@ | |||
| import {formatQS} from './url'; | |||
There was a problem hiding this comment.
I think this file should be named 'video.js' - since it's relating to video
There was a problem hiding this comment.
After discussion we decided to keep it adserver.js as of now. When more adservers are added it will be updated
| return formatURL(dfpAdserverObj.urlComponents); | ||
| } else { | ||
| utils.logError('Only DFP adserver is supported'); | ||
| return; |
|
@jaiminpanchal27 |
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 23, 2016
…3.0 to master * commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits) Added support for new adapters introduced in 0.13.0 into AOL analytics Updated CHANGELOG Fixed merge conflict Prebid 0.13.0 Release Resolves prebid#635 (prebid#640) Add IX Deal Support (prebid#638) Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641) added timeouts to rubicon adapter that consider time-to-start costs (prebid#629) Modify handling of no-bids in Krux Link adapter (prebid#628) Allow bypassing ajax preflights with config options (prebid#630) validateIndentation: Invalid indentation character (prebid#631) use `splice` rather than `slice` to remove bids from array (prebid#637) delete the callback before calling clearAuction (prebid#636) Deal override fix to resolve prebid#618 (prebid#619) Update package.json Video - create mastertagUrl from adservertag (prebid#614) Prevent renderAd from rendering videos (prebid#623) Remove unused build depencencies (prebid#622) Add pull request template (prebid#615) Openx adaptor deal update (prebid#612) ...
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Support video demand requests for video-enabled adUnits * Refactor and write unit tests * Enable adapters to register as supporting video * Pass adUnit mediaType to adapters * Place helper functions at module-level * Master video tag from adservertag * Add example page with setup for video placement * Move helper functions to video module * Clarify error message * Updates * master tag function updates * Moved adserver code to separate file * Video mastertag updates after code review and test cases * Changed key in bid object (adUrl to vastUrl) * update example file * Update example
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Support video demand requests for video-enabled adUnits * Refactor and write unit tests * Enable adapters to register as supporting video * Pass adUnit mediaType to adapters * Place helper functions at module-level * Master video tag from adservertag * Add example page with setup for video placement * Move helper functions to video module * Clarify error message * Updates * master tag function updates * Moved adserver code to separate file * Video mastertag updates after code review and test cases * Changed key in bid object (adUrl to vastUrl) * update example file * Update example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.