Allow bypassing ajax preflights with config options #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
requested changes
Sep 15, 2016
| @@ -54,8 +54,11 @@ export function ajax(url, callback, data, options = {}) { | |||
| if (options.withCredentials) { | |||
| x.withCredentials = true; | |||
| } else { | |||
| x.setRequestHeader('X-Requested-With', 'XMLHttpRequest'); | |||
| x.setRequestHeader('Content-Type', 'application/json;charset=UTF-8'); | |||
| if (options.preflight !== false) { | |||
There was a problem hiding this comment.
Any reason for the double negation here? Also don't see why we can't use withCredentials with preflight. IMO these should all be standalone options
| x.setRequestHeader('X-Requested-With', 'XMLHttpRequest'); | ||
| } | ||
| x.setRequestHeader('Content-Type', | ||
| options.contentType || 'application/json;charset=UTF-8'); | ||
| } |
There was a problem hiding this comment.
this will also have to be updated, as content other than application/x-www-form-urlencoded, multipart/form-data, or text/plain requires a preflight request. In other words, application/json will trigger preflight.
manhhailua
approved these changes
Sep 15, 2016
| @@ -54,8 +54,11 @@ export function ajax(url, callback, data, options = {}) { | |||
| if (options.withCredentials) { | |||
| x.withCredentials = true; | |||
| } else { | |||
| x.setRequestHeader('X-Requested-With', 'XMLHttpRequest'); | |||
| x.setRequestHeader('Content-Type', 'application/json;charset=UTF-8'); | |||
| if (options.preflight !== false) { | |||
There was a problem hiding this comment.
These code will let preflight requests become default behavior. Is it intential?!
mkendall07
approved these changes
Sep 16, 2016
|
LGTM. |
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 23, 2016
…3.0 to master * commit '9d4bc7fda6bcc249544fb8636b98e90fdc8d474b': (44 commits) Added support for new adapters introduced in 0.13.0 into AOL analytics Updated CHANGELOG Fixed merge conflict Prebid 0.13.0 Release Resolves prebid#635 (prebid#640) Add IX Deal Support (prebid#638) Bug fix: accept custom timeout prebid#582 & prebid#604 (prebid#641) added timeouts to rubicon adapter that consider time-to-start costs (prebid#629) Modify handling of no-bids in Krux Link adapter (prebid#628) Allow bypassing ajax preflights with config options (prebid#630) validateIndentation: Invalid indentation character (prebid#631) use `splice` rather than `slice` to remove bids from array (prebid#637) delete the callback before calling clearAuction (prebid#636) Deal override fix to resolve prebid#618 (prebid#619) Update package.json Video - create mastertagUrl from adservertag (prebid#614) Prevent renderAd from rendering videos (prebid#623) Remove unused build depencencies (prebid#622) Add pull request template (prebid#615) Openx adaptor deal update (prebid#612) ...
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Allow bypassing ajax preflights with config options * Make preflight opt-in and set default content-type to text-plain
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Allow bypassing ajax preflights with config options * Make preflight opt-in and set default content-type to text-plain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This change allows ajax calls to be configured with two options related to sending preflight OPTIONS requests. Setting
preflightto false, and settingcontentTypeto one ofapplication/x-www-form-urlencoded,multipart/form-data, ortext/plainwill prevent a preflight OPTIONS request. Example of setting these options:Other information
Addresses #625