🚀 Release LLD 2022-09-20 #1326
Merged
🚀 Release LLD 2022-09-20 #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* LIVE-3570: Switch to swap backend API v4 * Test getSwapAPIVersion * Fix responseV4 type Replace use of Map by JS object because the Map can't be automatically constructed by typescript type casting. It needs to be created by calling the Map object constructor `Map()` * Test getProviders function * add changeset Co-authored-by: Alexandre Chabrolin <[email protected]>
Co-authored-by: Luis Perrone <[email protected]>
* provide a formatDeviceAmount helper for the bot * Update EVM fam specs to use EIP1559 props for fees Co-authored-by: lambertkevin <[email protected]>
* feat: post onboarding author Olivier Freyssinet <[email protected]> 1660815558 +0200 committer Olivier F <[email protected]> 1661187186 +0200 feat: post onboarding PostOnboardingHub screen ground work + debug settings + screen for mocking features with "done" button Use correct typo for title & subtitle of hub screen Add largeLineHeight variant to native-ui text Use correct typographic styles & colors in post onboarding hub Move post onboarding types to LLC Add POST_ONBOARDING_CLEAR_LAST_ACTION_COMPLETED action fix bracketSizes type Rename & document hooks Fix PostOnboardingMockActionScreen Move post onboarding to own navigator Clear last action completed when leaving closing hub screen feat(native-ui): new variant "plain" for Notification component Implement logic for closing popup in PostOnboardingHub Fix bad style in native-ui getTextStyle (missing unit in styled component) Remove "all done" state confettis in hub Reword "setActionDone" to "setActionCompleted" Fix import of postOnboardingState (don't add to store if value is falsy) Add post onboarding entry point on portfolio/wallet screen Implement new tag variants from figma Change icons & shorten text of mock post onboarding actions Use new tag styling Set logic for mocking post onboarding actions Add animated success screen Improve placeholder text Cleanup (rename mock actions as such, cleanup documentation, remove useless hook) Improve wording of debug settings Fix warning in PostOnboardingHub Fix post rebase Fix color of placeholder img in entry point card Fix feature flagging of post onboarding actions lint Tag component changesets Add guides for implementation of post onboarding action for each device model Add startPostOnboarding at the end of existing onboarding Fix useStartPostOnboardingCallback not always overriding state Improve navigation to main screen lint changeset Migrate postOnboarding types to types-live Add tracking of post onboarding action start docs & rename ActionState type Remove placeholder type Better use of design system spacing & radii scales Rename `icon` > `Icon` to follow component naming convention Use deep comparison of post onboarding state before saving it in db Cleanup some types & comments Fix potential crash on falsy value lint Use Divider from design system Add todos Try moving state logic to LLC (not working for now bc of react-redux) pnpm i remove /lib/postOnboarding imports remove /lib imports in postOnboarding/hooks Revert change on portfolio index Force react-redux dep in LLM metro config (thank you Julien you saved the day 🙏) chore: remove react-native from react-redux peer deps Slightly more elegant way of fixing LLM/LLC react-redux duplicate package issues live-common changesets Fix bad use of importPostOnboardingState action creator lint install deps post rebase fix bad merge fix reducer missing post rebase Fix ts (post rebase) Force react-redux dep in LLM metro config chore: remove react-dom from react-redux peer deps Fix typing of PostOnboardingProvider props Move hooks to their own file rename hooks.tsx to useNavigateToPostOnboardingHubCallback.ts no import from "." Remove log some unit tests, more coming tomorrow this is boring to death Add tests for usePostOnboardingHubState Unit test postOnboarding reducer & actions creators give this code some room to breathe fix PostOnboarding routes typing improve test clarity fix post rebase fix doc remove @ts-expect-error lint lint again lint Fix post rebase Fix post rebase Fix remove bad comment on portfolio Remove useless hooks Rename onStartEvent->startEvent, onStartEventProperties->startEventProperties File apps/ledger-live-mobile/src/locales/en/common.json was updated on ru-RU locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on de-DE locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on ko-KR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on pt-BR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on es-ES locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on tr-TR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on ar-AE locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on fr-FR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on zh-CN locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on ja-JP locale Prevent closing the onboarding hub during the end animation Add delay prop to Transitions.Fade Fade out the notification at the bottom doc:ljs Remove usePostOnboardingDeviceModelId, useSetActionCompletedCallback lint fix post rebase * Improve cleanup of triggerEndAnimation * Smartling translations are updated for PR#943 from feat/FAT-156-post-onboarding (#1251) * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ru-RU locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on de-DE locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ko-KR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on pt-BR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on es-ES locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on tr-TR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ar-AE locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on fr-FR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on zh-CN locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ja-JP locale * update pods Co-authored-by: Ledger Live <[email protected]>
* Remove legacy code & assets in LLD onboarding * fix: devices name Co-authored-by: Pierre-Louis Crescitz <[email protected]>
…rimental features
Update specs.ts
…tions (#1104) * FAT-356 Update onboarding states according to the new firmware definitions * FAT-356 Add changelog
bugfix(TabBar): Wrap text when is too long in TabBar Tansfer
…send-nft support(Disclaimer):Error message when trying to send a NFT from LNS is wrong
fix: add swap title color LIVE-3846
…-callback-issue LIVE-3905 - LLD - fix toast issue when no click callback given
* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ar-AE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to zh-CN locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to fr-FR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to de-DE locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ja-JP locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ko-KR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to pt-BR locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ru-RU locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to es-ES locale * File apps/ledger-live-desktop/static/i18n/en/app.json was translated to tr-TR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale * File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale
matthieu-krief
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next release is on the way 🚀!
This pull request is the next release in the Ledger Live JS ecosystem.
Checklist
To be ready to be merged, we must comply with all theses checks:
/!\ If this release includes a new version of Ledger Live Desktop
Once all these checks are validated, the pull request can be merged using the correct workflow.