Merge update upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optimize layout flattening * Changelog * Remove whitespace * Update ASLayout.mm Add comment
upgrading.html => adoption-guide-2-0-beta1.html Testing this doesn't quite work in preview as the path differs a bit from when its accessible through the normal resolver. I assume this will substitute the last path slug and the server maps `_docs` to `docs` https://github.com/TextureGroup/Texture/tree/master/docs/_docs
…ivial (#984) * Add missing instance variables in ASTextNode and warnings cleanup * Re-add drain
* Adds support for having multiple interface state delegates. Hopefully in a performant way. * Switch to respondsToSelector for int del instead of separate object * Add CHANGELOG * Make ASDisplayNode+InterfaceState.h public * Huy's comments * Don't even bother removing since it's a weak hash table.
* Create transfer-array method and use it * License headers * Update ASArrayByFlatMapping
* Remove yoga layout spec, which has been superseded by tighter yoga-display node integration * Changelog
* Properly consider node for responder methods * Add changelog
* Rewrite Swift Example * Add license header to OrderedDictionary
* Introduce let / var and some further cleanup * Address first comments * Update changelog * Move the const before auto
…oxy (#1015) * Adds missing UIScrollViewDelegate method to IGListKit proxy implementation * Updates CHANGELOG
…g node measurement (#1022) - Currently, there is a pair of mutex unlock and unlock that wraps around `-_u_measureNodeWithBoundsIfNecessary:` in `__layout`. That is because this method must be called without the lock. - When an assertion occurs within that method, the runtime bails early without reacquire the lock (so the lock is free now). However, the runtime then hits the end of the outmost mutex locker scope and tries to release the lock that it no longer holds, causing another assertion in ASThread to be shown to user (#932). This makes it extremely hard to idenfity the root assertion. - Fix by replacing the unlock/lock pair with a mutex unlocker.
…e's instance lock #trivial (#1023) This is because committing the layout transition (aka `-_completeLayoutTransition:`) results in subnode insertions and removals which must be called lock-free.
* Add move detection and support to ASLayoutTransition ...and NSArray+Diffing. Add some tests. * Update CHANGELOG.md * Update CHANGELOG.md * Update ASLayout+IGListKit.h * Update ASLayout+IGListKit.mm * Use std collections to avoid NSNumber boxing * Update ASLayoutTransition.mm * Code review updates. * Use `unordered_multimap` on stack instead of unordered_map<id,queue> on heap * Remove notFound BOOL (use NSNotFound sentinel value) and put some vars inside the if (insertions/moves) loop * Don't copy defaultCompare block (redundant under ARC) * Whitespace * Remove unneeded mutableCopy-s in ArrayDiffingTests * Code review updates. * Type _subnodeMoves pair.first to ASDisplayNode * instead of id * C++ enumeration * unowned refs for adding previousLayout nodes to _subnodeMoves * Remove unreleated ASDynamicCast that is probably right though * Add commentary to NSArray+Diffing.h; make multimap elements unowned * Use std::make_pair, optimize ASLayout+IGListKit * Oops I thought I had added these headers but nope * Simplify simplify * Diff subnodes instead of sublayouts * Another randomized test with actual ASLayouts
- Rename `ASDisplayNodeAssertLockUnownedByCurrentThread` to `ASAssertUnlocked`, and `ASDisplayNodeAssertLockOwnedByCurrentThread` to `ASAssertLocked` -> shorter and hopefully easier to distinguish between the two. - Add assertions to `_locked_` and `_u_` (i.e "unlocked") methods. - Turn `CHECK_LOCKING_SAFETY` flag on by default. After #1022 and #1023, we're in a good shape to actually enforce locked/unlocked requirements of internal methods. Our test suite passed, and we'll test more at Pinterest after the sync this week. - Fix ASVideoNode to avoid calling `play` while holding the lock. That method inserts a subnode and must be called lock free. - Simplify `_loaded(node)` to only nil-check `_layer` because regardless of whether the node is view or layer backed, the layer should always be set if loaded. Use it throughout. - Other minor changes.
…size and dynamic linking time when they're not needed (#1028)
* Remove NSMutableArray for retaining sublayout elements * Kick the CI * Kick the CI again * Smash that CI button * Murder the CI
* Turn off exceptions to reduce binary size * Changelog
…1029) * Create and use ASDisplayNodeCornerLayerDelegate * Return kCFNull for actionForLayer:forKey:
…er of the superclass '-init' not found #trivial (#1036) * Fix warning for ASLayout method override for the designated initializer of the superclass '-init' not found * Move unavailable init into header
* Reuse interface state delegates when calling out instead of always copying
* fix SIMULATE_WEB_RESPONSE not imported #449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Make interface state delegate protocol non-optional. * add change log * add missing removal * add required method to ASNodeController * fix indentation * Update CHANGELOG.md
* Improve locking around clearContents * Add changelog
* let / var macros did not make it to 2.7 * moved change note later in the log to reflect actual timeline * Update CHANGELOG.md
* fix SIMULATE_WEB_RESPONSE not imported #449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Do not cancel on exit, interface state update should handle it. * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * add space to trigger ci * add change log
* fix SIMULATE_WEB_RESPONSE not imported #449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Fix interface state not update correctly during layer thrash * add change log
- Fix typos in ASEditableTextNode.h and ASDisplayNode+FrameworkPrivate.h. - Remove unnecessary declaration for ASPINRemoteImageDownloader's sharedDownloader class property. - Remove unnecessary empty lines in ASPINRemoteImageDownloader.m and ASEditableTextNode.h.
* Remove use of NSHashTable for interface state delegates #trivial * Stray line * One more case * Add code to let people have more delegates * Do it more
…RemoteImageManager (#1124) * add a method for setting preconfigured PINRemoteImageManager instead of using the self-created ASPINRemoteImageManager * update preconfigured image manager where it can only be set once * fix spacing in downloader * Fix doc/comments on new api * adding assertion to ensure either only configuration or preconfigure image manager can be set at a time * adding assertion to ensure either only configuration or preconfigure image manager can be set at a time * fix assertion condition * Update CHANGELOG.md * Remove unnecessary change
…nager:'s doc #trivial (#1126)
…, ASCollectionNode (#1103)
* Remove reliance on shared_ptr for ASDisplayNodeLayouts * Fix up * Fix in yoga * Back to let * Returns inner pointer * Trivial change to kick the CI
* Apply recommended warnings * Squelch designated initializer warning in ASViewController * Remove unused compiler flag clang: warning: argument unused during compilation: '-fno-objc-arc-exceptions' [-Wunused-command-line-argument] * Fix warning about overriding an instance variable within a category Instance method 'methodOverrides' in category from _ASDisplayView.o overrides method from class in ASDisplayNode.o
* Add ASExperimentalSkipClearData * Move the experiment check within the if clause
* fix SIMULATE_WEB_RESPONSE not imported #449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Only test when photo library is enabled. It will fail to build if photo library is disabled cause the test is depending on it. * Add ChangeLog.
mikezucc
pushed a commit
that referenced
this pull request
Nov 7, 2018
…1154) This is a follow up on TextureGroup#1136. Our experiment results show that clearing data frequently is the cause of our #1 crash. @maicki and I believe that this is because if the collection view is being used, silently clearing its data without notifying the backing UICollectionView can put it out-of-sync and causes mayhem next time the collection view processes a batch update. If you look at the stack trace closely, you'll notice that the crash doesn't occur on the same run loop that clearData is called. This made it extremely tricky to investigate and identify the root cause. Another interesting question would be whether or not we want to clear the data during deallocation at all, since the data will be cleared out soon anyway.
mikezucc
pushed a commit
that referenced
this pull request
Nov 7, 2018
…1154) This is a follow up on TextureGroup#1136. Our experiment results show that clearing data frequently is the cause of our #1 crash. @maicki and I believe that this is because if the collection view is being used, silently clearing its data without notifying the backing UICollectionView can put it out-of-sync and causes mayhem next time the collection view processes a batch update. If you look at the stack trace closely, you'll notice that the crash doesn't occur on the same run loop that clearData is called. This made it extremely tricky to investigate and identify the root cause. Another interesting question would be whether or not we want to clear the data during deallocation at all, since the data will be cleared out soon anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.